Added fixes for QIF files with different date order and syntax#21
Open
jmcameron wants to merge 5 commits into
Open
Added fixes for QIF files with different date order and syntax#21jmcameron wants to merge 5 commits into
jmcameron wants to merge 5 commits into
Conversation
Author
|
Converted more Decimal() calls to convertFloat() calls for values that should be floats. |
Author
|
Regtests now pass on Travis CI! |
Author
|
In the last update to this pull request, I added support the 'U' field (seems like another amount for transactions) and named it 'amount_U' since I could not find any documentation on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into difficulties with QIF files exported by an old version of Quicken. Some of the numbers had embeded commas (for thousands separators) and the date as in DD/MM'YY format instead of MM/DD'YY format the code expects. I added a couple of class-level flags for this. Normal use should not change, but By giving extra (optional) arguments to the .parse() command, it handles my odd formats too.
I changed the Decimal(str) use to use a special function that removes the embedded thousands separators (commas by default, but overrideable) before doing the conversion to a flow. I only did it where I had difficulties (processing transactions); you may want to change the rest correspondingly.